From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 182622538C for ; Wed, 24 Jul 2019 13:35:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pcrofjs0NE6g for ; Wed, 24 Jul 2019 13:35:48 -0400 (EDT) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B01DE25387 for ; Wed, 24 Jul 2019 13:35:47 -0400 (EDT) Received: by mail-lf1-f67.google.com with SMTP id r15so15535830lfm.11 for ; Wed, 24 Jul 2019 10:35:47 -0700 (PDT) Date: Wed, 24 Jul 2019 20:35:43 +0300 From: Cyrill Gorcunov Subject: [tarantool-patches] Re: [PATCH 5/5] box/lua/console: Limit lua output for local sessions only Message-ID: <20190724173543.GN4832@uranus.lan> References: <20190723223113.16084-1-gorcunov@gmail.com> <20190723223113.16084-6-gorcunov@gmail.com> <20190724171537.GE4764@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190724171537.GE4764@atlas> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Konstantin Osipov Cc: tml , Alexander Turenko , Kirill Yukhin On Wed, Jul 24, 2019 at 08:15:37PM +0300, Konstantin Osipov wrote: > * Cyrill Gorcunov [19/07/24 01:35]: > > To make full support of lua mode on remote connection we > > need pass this option to remote server. Also we need to > > provide a compatibility layer for servers from previous > > series and thus recode yaml output on client side. > > > > This will be done in next patches, for now simply limit > > the usage of lua output to local sessions only. > > > > Part-of #3834 > > --- > > src/box/lua/console.lua | 30 ++++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > I don't think this patch is necessary, or we need to do anything > about remote consoles. What we have is good enough - remote format > is used. We can simply document it. > Whoever doesn't like the remote format, can change it right after > connecting to the remote. > > Not pushing. I see. Need to implement deep testing of all this.