From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EB7CC2536D for ; Wed, 24 Jul 2019 13:10:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R4CkyF2g0yBI for ; Wed, 24 Jul 2019 13:10:09 -0400 (EDT) Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id AE1332209F for ; Wed, 24 Jul 2019 13:10:09 -0400 (EDT) Date: Wed, 24 Jul 2019 20:10:07 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] sql: fix type in meta for unsigned binding Message-ID: <20190724171007.GB4764@atlas> References: <20190724165508.81356-1-korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190724165508.81356-1-korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Nikita Pettik Cc: tarantool-patches@freelists.org * Nikita Pettik [19/07/24 19:59]: > It was decided that for all integer literals we would return "INTEGER" > type, not "UNSIGNED". Accidentally, after substitution of unsigned > binding value type was set to "UNSIGNED". Let's fix that and set > "INTEGER" type. the patch is lgtm but I'm not sure it covers all cases. I've seen a lot of unsigned inthe tests. -- Konstantin Osipov, Moscow, Russia