From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AB8C4252B5
	for <tarantool-patches@freelists.org>; Wed, 24 Jul 2019 13:09:36 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Xf8uB0oQ6irF for <tarantool-patches@freelists.org>;
	Wed, 24 Jul 2019 13:09:36 -0400 (EDT)
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 637FB2209F
	for <tarantool-patches@freelists.org>; Wed, 24 Jul 2019 13:09:36 -0400 (EDT)
Date: Wed, 24 Jul 2019 20:09:34 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 5/6] sql: introduce extended
 range for INTEGER type
Message-ID: <20190724170934.GA4764@atlas>
References: <cover.1559919361.git.korablev@tarantool.org>
 <de2d1b46e87588dce2f9d56df1ded44afdd5c052.1559919361.git.korablev@tarantool.org>
 <20190724155923.GA1031@atlas>
 <01A073A1-0F44-4A8C-A282-509BC0C74CA3@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <01A073A1-0F44-4A8C-A282-509BC0C74CA3@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org

* n.pettik <korablev@tarantool.org> [19/07/24 19:54]:
> 
> But failed (simply forgot) to fix that for binding values.
> So, juts want to clarify: we never set “UNSIGNED” type for
> literals, even if they are in range [2^63, 2^64-1], right?
> 
> If so, patch turns out to be pretty simple.

Yes, I think UNSIGNED is only storage type, we never should deliberately use
UNSIGNED values in vdbe, INTEGER is powerful enough to always use it.

Of course if we get UNSIGNED from the storage layer, we need to
preserve its type.

-- 
Konstantin Osipov, Moscow, Russia