From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 839FF25380 for ; Wed, 24 Jul 2019 13:00:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0PyUD8d2LtIF for ; Wed, 24 Jul 2019 13:00:48 -0400 (EDT) Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 400FC25378 for ; Wed, 24 Jul 2019 13:00:48 -0400 (EDT) Date: Wed, 24 Jul 2019 20:00:45 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v4 0/5] box/lua/console: Add initial support for lua output format Message-ID: <20190724170045.GA4565@atlas> References: <20190723223113.16084-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190723223113.16084-1-gorcunov@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Cyrill Gorcunov Cc: tml , Alexander Turenko , Kirill Yukhin * Cyrill Gorcunov [19/07/24 01:35]: > Hi, here is an updated series for lua console support. It is in devel state > still since we need to enhance output support for remote connections. By > now I limit this mode for local sessions only. > > Main purpose of this series is to not break anything existing thus requires > a deep testing. I checked in some patches from this branch with minor remarks. Please add tests. > TODO: > - extend exchange protocol with remote nodes to pass current output > mode and get ack/nack to process > - add compat layer for old remote server which do not have lua output > support at all and will provide us yaml output regarding of anything > - rework "help" and turorial output since in lua mode they are simply > unreadable > - extend test engine so that new tests would use lua output by default > (should we?) I agree with the todo. Yes, we should switch to this format universally. -- Konstantin Osipov, Moscow, Russia