From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E6C892532E
	for <tarantool-patches@freelists.org>; Wed, 24 Jul 2019 11:59:25 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id vNnie7y96TkO for <tarantool-patches@freelists.org>;
	Wed, 24 Jul 2019 11:59:25 -0400 (EDT)
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A7F3B2532A
	for <tarantool-patches@freelists.org>; Wed, 24 Jul 2019 11:59:25 -0400 (EDT)
Date: Wed, 24 Jul 2019 18:59:23 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 5/6] sql: introduce extended range
 for INTEGER type
Message-ID: <20190724155923.GA1031@atlas>
References: <cover.1559919361.git.korablev@tarantool.org>
 <de2d1b46e87588dce2f9d56df1ded44afdd5c052.1559919361.git.korablev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <de2d1b46e87588dce2f9d56df1ded44afdd5c052.1559919361.git.korablev@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>

* Nikita Pettik <korablev@tarantool.org> [19/06/07 23:30]:
> @@ -72,11 +72,11 @@ execute('SELECT ?, ?, ?', {1, 2, 3})
>  ---
>  - metadata:
>    - name: '?'
> -    type: INTEGER
> +    type: UNSIGNED
>    - name: '?'
> -    type: INTEGER
> +    type: UNSIGNED
>    - name: '?'
> -    type: INTEGER
> +    type: UNSIGNED
>    rows:
>    - [1, 2, 3]

Nikita,

I know this decision came after you coded most of the patch, but
we agreed that unsigned integer literals should still have
"INTEGER" type, not "UNSIGNED", since INTEGER in tarantool fully
covers UNSIGNED range.

This leads to fewer surprises to users, e.g. when calculating
expression types. Could you please fix this?

> 

-- 
Konstantin Osipov, Moscow, Russia