From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8DEDB2405A for ; Wed, 24 Jul 2019 10:10:08 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aH_lQViQ1Pn1 for ; Wed, 24 Jul 2019 10:10:08 -0400 (EDT) Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 75B8320F9C for ; Wed, 24 Jul 2019 10:10:07 -0400 (EDT) Date: Wed, 24 Jul 2019 17:10:04 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: increase row_count when adding CHECK constraint Message-ID: <20190724141004.qe7q6saruyf5evyo@tarantool.org> References: <5dba4410ecdc97004cd4a9890e302baa20b07529.1563525363.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5dba4410ecdc97004cd4a9890e302baa20b07529.1563525363.git.imeevma@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org Hello, On 19 Jul 11:38, imeevma@tarantool.org wrote: > If a CHECK constraint was added using an ALTER TABLE statement, > row_count should be increased. Note that row_count does not > increase if a CHECK constraint is added during the execution of a > CREATE TABLE statement. > For example: > > box.execute('CREATE TABLE t1(id INTEGER PRIMARY KEY);') > box.execute('ALTER TABLE t1 ADD CONSTRAINT ck1 CHECK(id > 0);') > > Should return: > - row_count: 1 > > However it was '0' before the patch. > > Closes #4363 > --- > https://github.com/tarantool/tarantool/issues/4363 > https://github.com/tarantool/tarantool/tree/imeevma/gh-4363-increase-row_count-on-alter-table I've checked your patch into master. -- Regards, Kirill Yukhin