From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7ED9723453 for ; Wed, 24 Jul 2019 04:04:14 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xwKRor8UAzK7 for ; Wed, 24 Jul 2019 04:04:14 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2F4C1220AD for ; Wed, 24 Jul 2019 04:04:14 -0400 (EDT) Date: Wed, 24 Jul 2019 11:03:56 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] build: enable bundled libyaml for all systems. Message-ID: <20190724080356.3fnex2nzzdfiesjn@tkn_work_nb> References: <20190721132557.4519-1-sergepetrenko@tarantool.org> <1563832103.596220876@f281.i.mail.ru> <20190723094016.jzswrwj2zrqheedv@tkn_work_nb> <1563906321.235667177@f430.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1563906321.235667177@f430.i.mail.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Sergey Petrenko Cc: tarantool-patches@freelists.org, Kirill Yukhin So, I'm okay. Thanks! Kirill, can you proceed? We need to push sp/static-linking into libyaml's master, update the submodule in tarantool and push sp/gh-4090-enable-bundled-libyaml-full-ci into tarantool. issue: https://github.com/tarantool/tarantool/issues/4090 WBR, Alexander Turenko. On Tue, Jul 23, 2019 at 09:25:21PM +0300, Sergey Petrenko wrote: > Hi! > > > >Вторник, 23 июля 2019, 12:40 +03:00 от Alexander Turenko : > > > >> I addressed this issue in a patch to tarantool/libyaml. Please check it out. > >> This patch remains intact. > > > >Okay. I don't have objections, but one comment. > > > >> >> - set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w") > >> >> + set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w -std=c99") > > > >Maybe it worth to declare a loop variable outside a loop initialization > >statement in libyaml (and update the upstream PR)? I mean that if all > >libyaml code follow C89, then we maybe should do it too in our changes. > >What do you think? > This seems reasonable. > I updated both branches > ( https://github.com/tarantool/libyaml/tree/sp/static-linking  and  > https://github.com/tarantool/tarantool/tree/sp/gh-4090-enable-bundled-libyaml-full-ci ) > I've also updated the pull request to libyaml upstream. > > > > > > > > -- > Sergey Petrenko