From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 85E9B24E96
	for <tarantool-patches@freelists.org>; Tue, 23 Jul 2019 10:53:08 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id jqNpQOclvyVs for <tarantool-patches@freelists.org>;
	Tue, 23 Jul 2019 10:53:08 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CB09724E73
	for <tarantool-patches@freelists.org>; Tue, 23 Jul 2019 10:53:07 -0400 (EDT)
Date: Tue, 23 Jul 2019 17:52:49 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 2/2] say: take getaddrinfo() errors  into account
Message-ID: <20190723145249.5xwc2td6omphwwzw@tkn_work_nb>
References: <cover.1561469272.git.roman.habibov@tarantool.org>
 <3603f7507651b37ddd549a8c247709cc7ff43f44.1561469272.git.roman.habibov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3603f7507651b37ddd549a8c247709cc7ff43f44.1561469272.git.roman.habibov@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@freelists.org

> @@ -594,6 +594,7 @@ log_syslog_init(struct log *log, const char *init_str)
>  	log->fd = log_syslog_connect(log);
>  	if (log->fd < 0) {
>  		/* syslog indent is freed in atexit(). */
> +		diag_log();

1. It is need to be properly commented: we need to log a diagnostics
here until stacked diagnostics will be implemented (#1148).

2. syslog_connect_unix() does not set a diag, diag_log() will lead to an
assertion fail.

3. I would mention this change in the commit message, because it is not
part of the problem with Mac OS you described in it.