From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EA3FE24772
	for <tarantool-patches@freelists.org>; Tue, 23 Jul 2019 05:40:34 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id VV9aSeV9YqWJ for <tarantool-patches@freelists.org>;
	Tue, 23 Jul 2019 05:40:34 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4EB4B23498
	for <tarantool-patches@freelists.org>; Tue, 23 Jul 2019 05:40:34 -0400 (EDT)
Date: Tue, 23 Jul 2019 12:40:16 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] build: enable bundled libyaml for all systems.
Message-ID: <20190723094016.jzswrwj2zrqheedv@tkn_work_nb>
References: <20190721132557.4519-1-sergepetrenko@tarantool.org>
 <20190722070957.b5vso3m7lccv2z7v@tkn_work_nb>
 <1563832103.596220876@f281.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1563832103.596220876@f281.i.mail.ru>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Sergey Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org

> I addressed this issue in a patch to tarantool/libyaml. Please check it out.
> This patch remains intact.

Okay. I don't have objections, but one comment.

> >> -    set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w")
> >> +    set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w -std=c99")

Maybe it worth to declare a loop variable outside a loop initialization
statement in libyaml (and update the upstream PR)? I mean that if all
libyaml code follow C89, then we maybe should do it too in our changes.
What do you think?