From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C803E25516 for ; Sat, 20 Jul 2019 15:07:33 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zJat5sV2FHeb for ; Sat, 20 Jul 2019 15:07:33 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 18A0725510 for ; Sat, 20 Jul 2019 15:07:32 -0400 (EDT) Date: Sat, 20 Jul 2019 22:07:15 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] net.box: ignore absence of _vcollation Message-ID: <20190720190714.5pejxoy2ae43nssp@tkn_work_nb> References: <20190708121338.76309-1-roman.habibov@tarantool.org> <20190712095549.ac4hhaxhxzgaik5i@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190712095549.ac4hhaxhxzgaik5i@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Yukhin Cc: tarantool-patches@freelists.org, Roman Khabibov , Konstantin Osipov > > diff --git a/src/box/lua/net_box.lua b/src/box/lua/net_box.lua > > index 2892bb3d3..723e63045 100644 > > --- a/src/box/lua/net_box.lua > > +++ b/src/box/lua/net_box.lua > > @@ -761,6 +761,11 @@ local function create_transport(host, port, user, password, callback, > > if status ~= 0 then > > local body > > body, body_end = decode(body_rpos) > > + local err_msg = 'Space \'277\' does not exist' > > Space 277? Seriously? This code handles not only collations request. > Should be more generic, IMHO. Of course, it is better to use VCOLLATION_ID constant that already defined above. Kirill, I didn't got your comment. This error message is only about one specific case: there is no such space. I think this approach is better then version check (that is proposed in the next version of the patch), because of readability: the version check approach leads to many small if's, while here we add only one check. BTW, Kostja also has a comment: https://github.com/tarantool/tarantool/commit/47227cfa4c9bac76a882464a2d0440e5137f158e#commitcomment-34342515 WBR, Alexander Turenko.