From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id F1AA224D78 for ; Sat, 20 Jul 2019 03:42:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1-63Ewz5FMBJ for ; Sat, 20 Jul 2019 03:42:13 -0400 (EDT) Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5986024D63 for ; Sat, 20 Jul 2019 03:42:13 -0400 (EDT) Date: Sat, 20 Jul 2019 10:42:10 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL Message-ID: <20190720074210.GA27751@atlas> References: <5863bb4286a3e45b3521420273d89347bd331a92.1563576462.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5863bb4286a3e45b3521420273d89347bd331a92.1563576462.git.v.shpilevoy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org * Vladislav Shpilevoy [19/07/20 01:52]: > index 000000000..8f7f91151 > --- /dev/null > +++ b/test/sql/ddl.result > @@ -0,0 +1,356 @@ > +-- test-run result file version 2 > +test_run = require('test_run').new() > + | --- > + | ... > +engine = test_run:get_cfg('engine') > + | --- Just curious why did you choose Lua test format and not SQL? Now that SQL format is in place my personal preference would be is that it is used for SQL tests whenever possible, to improve readability (SQL syntax highlighting, autocompletion). What do you miss in SQL tests format? I personally only miss anonymous sql/psm blocks and loops. -- Konstantin Osipov, Moscow, Russia