From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 18 Jul 2019 07:50:25 +0300 From: Kirill Yukhin Subject: Re: [tarantool-patches] [PATCH] Extend range of printable unicode characters Message-ID: <20190718045025.wt373bnoflygqc3j@tarantool.org> References: <20190716134331.15327-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190716134331.15327-1-sergepetrenko@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, alexander.turenko@tarantool.org, Serge Petrenko List-ID: Hello, On 16 Jul 16:43, Serge Petrenko wrote: > Before the patch IS_PRINTABLE macros was used > to determine if given character is printable or not. > This macros did not take into account characters > encoded with 4 bytes. > After the patch IS_PRINTABLE is replaced with new > corresponding function. Now the range of printable > characters is: (libyaml old range) U (icu range). This > new range include characters encoded with 4 bytes. > > Related to tarantool/tarantool#4090 > --- > https://github.com/tarantool/libyaml/tree/tarantool-gh-4090-fix > https://github.com/tarantool/tarantool/issues/4090 New parsers are out of scope 2.2 release series, so I've checked your patch into master. Serge, please don't forget to upstream the patch. -- Regards, Kirill Yukhin