From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6F13924698 for ; Thu, 18 Jul 2019 00:27:29 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w1IntUBBRYVW for ; Thu, 18 Jul 2019 00:27:29 -0400 (EDT) Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 259FA21925 for ; Thu, 18 Jul 2019 00:27:29 -0400 (EDT) Date: Thu, 18 Jul 2019 07:27:26 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v1 1/1] box: increase connection timeout in "net.box.test.lua" Message-ID: <20190718042726.bn62yr6h6gp64vyr@tarantool.org> References: <667a69a7b37236d443212da8289c34d2bc56c722.1563185673.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <667a69a7b37236d443212da8289c34d2bc56c722.1563185673.git.imeevma@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, avtikhon@tarantool.org Hello, On 15 Jul 13:20, imeevma@tarantool.org wrote: > The "box/net.box.test.lua" test contains a check that the error > received contains a 'timed out'. But in cases when testing was > conducted on a slow computer or in the case of a very large load, > it is possible that the connection time-out will be reached > earlier than the mentioned error. In this case, the error "Invalid > argument" will be returned. To prevent this from happening, > this patch will increase the connection timeout. > > Closes #4341 I've checked your patch into master. -- Regards, Kirill Yukhin