From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D31E224698 for ; Thu, 18 Jul 2019 00:24:50 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E_g0NOhmfzxG for ; Thu, 18 Jul 2019 00:24:50 -0400 (EDT) Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 03DDA21925 for ; Thu, 18 Jul 2019 00:24:49 -0400 (EDT) Date: Thu, 18 Jul 2019 07:24:46 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v3 0/3] sql: clean-up in case constraint creation failed Message-ID: <20190718042446.edetkdpdlq2syvf5@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org Hello, On 04 Jul 13:49, imeevma@tarantool.org wrote: > This patch makes VDBE run destructors before halting in case > constraint creation failed. This is done using new opcode > OP_SetDiag, which allows to set an error and do a jump without > halting VDBE. > > https://github.com/tarantool/tarantool/issues/4183 > https://github.com/tarantool/tarantool/tree/imeevma/gh-4183-clean-up-when-constraint-creation-failed I've checked your patchset into master. -- Regards, Kirill Yukhin