From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 17 Jul 2019 17:34:54 +0300 From: Konstantin Osipov Subject: Re: [PATCH v3 1/4] box: introduce key_def->is_multikey flag Message-ID: <20190717143454.GD16650@atlas> References: <90d806637a4a9ccb48285beff02b3400d7058f07.1563326037.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90d806637a4a9ccb48285beff02b3400d7058f07.1563326037.git.kshcherbatov@tarantool.org> To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, vdavydov.dev@gmail.com List-ID: * Kirill Shcherbatov [19/07/17 09:39]: > Previously only key definitions that have JSON paths were able > to define multikey index. We used to check multikey_path != NULL > test to determine whether given key definition is multikey. > In further patches with functional indexes this rule becomes > outdated. Functional index extracted key definition may be > multikey, but has no JSON paths. > So an explicit is_multikey flag was introduced. The patch is lgtm, but shouldn't you also rename multikey_path to json_path? -- Konstantin Osipov, Moscow, Russia