From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3914425D17 for ; Fri, 12 Jul 2019 05:08:17 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ON80QI8Z1d5y for ; Fri, 12 Jul 2019 05:08:17 -0400 (EDT) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EF4DF25CDC for ; Fri, 12 Jul 2019 05:08:16 -0400 (EDT) Date: Fri, 12 Jul 2019 12:08:14 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v1 1/1] box: do not check state in case of reconnect Message-ID: <20190712090814.p3uwjvlhgkdwzzb7@tarantool.org> References: <03b9fb9b57353762ee6b9c8fb12fc3dd4c177eb7.1562854125.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <03b9fb9b57353762ee6b9c8fb12fc3dd4c177eb7.1562854125.git.imeevma@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, avtikhon@tarantool.org Hello, On 11 Jul 17:12, imeevma@tarantool.org wrote: > Test box/net.box.test.lua checks state of the connection in case > of an error. It should be 'error_reconnect'. But, in cases where > testing was performed on a slow computer or in the case of a very > large load, it is possible that the connection status may change > from the 'error_reconnect' state to another state. This led to the > failure of the test. Since this check is not the main purpose of > the test, it is better to simply delete the check. > > Closes #4335 > --- > https://github.com/tarantool/tarantool/issues/4335 > https://github.com/tarantool/tarantool/tree/imeevma/gh-4335-reconnect-state-error I've checked the patch into master. -- Regards, Kirill Yukhin