From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D812424EB6 for ; Wed, 10 Jul 2019 15:18:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IdUL69cQN3ok for ; Wed, 10 Jul 2019 15:18:13 -0400 (EDT) Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9684D24EAB for ; Wed, 10 Jul 2019 15:18:13 -0400 (EDT) Date: Wed, 10 Jul 2019 22:18:11 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 08/12] sql: rfc for SQL and Lua functions Message-ID: <20190710191811.GJ5619@atlas> References: <53e0ef51750696b33729dfcb38a269f1ee159112.1562756438.git.kshcherbatov@tarantool.org> <20190710191705.GI5619@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190710191705.GI5619@atlas> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, korablev@tarantool.org * Konstantin Osipov [19/07/10 22:17]: > What if I create TyPeOf function? Will this be allowed? > > The spec generally looks good to me, but I don't see how you > addressed the case sensitivity issue. Please add name_ucase field > to the _func definition, and add a unique index over it, to > prevent duplicates with a differently cased name. Sorry, forget this. Hit "send" too hastily. I noticed that you changed the unique index collation on "name" to case insensitive. Please mention this in the spec, I missed that at first. After that the spec is OK to push. -- Konstantin Osipov, Moscow, Russia