From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9B34B24E55 for ; Wed, 10 Jul 2019 15:09:43 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hwcPbDvt0T2P for ; Wed, 10 Jul 2019 15:09:43 -0400 (EDT) Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5509F24862 for ; Wed, 10 Jul 2019 15:09:43 -0400 (EDT) Date: Wed, 10 Jul 2019 22:09:40 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 04/12] sql: rework LIKE case-insensitive mode Message-ID: <20190710190940.GF5619@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, korablev@tarantool.org * Kirill Shcherbatov [19/07/10 14:02]: > The case_sensitive_like pragma used to process a strange way: on > each call a new instance of function having appropriate > properties was created. Reworked legacy code with user session > object to define this property there. The new approach allows > to rework sql builtins machinery with further patches. Querying like case sensitivity from the current session flags is extremely ugly, but this is being addressed in a separate commit by Roman. So LGTM. -- Konstantin Osipov, Moscow, Russia