From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B7A2E24E71 for ; Wed, 10 Jul 2019 14:45:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M15oheYBxdfi for ; Wed, 10 Jul 2019 14:45:13 -0400 (EDT) Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9673624E67 for ; Wed, 10 Jul 2019 14:45:12 -0400 (EDT) Date: Wed, 10 Jul 2019 21:45:10 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 01/12] sql: get rid of SOUNDEX, MATCH Message-ID: <20190710184510.GB5619@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, korablev@tarantool.org * Kirill Shcherbatov [19/07/10 14:02]: > In relation with FuncDef cache rework we need to clean-up > builtins list. The SOUNDEX function is not in use while MATCH > fucntion is a stub that raises an error, so they could be > dropped. > > Needed for #4182 I wonder why is SOUNDEX function disabled in Tarantool? sqlite makes it optional because it uses a static integer table, and sqlite is very concerned with memory footprint. We can simply always enable it, rather than remove. The rest of the patch is LGTM. -- Konstantin Osipov, Moscow, Russia