From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 45DDA2464B for ; Tue, 9 Jul 2019 18:24:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vg2iVC5Gt8af for ; Tue, 9 Jul 2019 18:24:48 -0400 (EDT) Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A8ED524611 for ; Tue, 9 Jul 2019 18:24:47 -0400 (EDT) Date: Wed, 10 Jul 2019 01:24:44 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/2] swim: pool IO tasks Message-ID: <20190709222444.GA19365@atlas> References: <20190705230136.GD30966@atlas> <609c7e7b-d8f7-413b-752c-94034bfd689b@tarantool.org> <20190708082521.GB24939@atlas> <35c77ced-50ea-faed-7d41-571020fbbfbb@tarantool.org> <20190708215432.GB7873@atlas> <050a79f5-847a-f184-2197-87cc789cfeab@tarantool.org> <20190708230807.GB11128@atlas> <743246c0-7780-2c1e-06d7-1c86d17140e6@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <743246c0-7780-2c1e-06d7-1c86d17140e6@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/07/09 23:48]: > The patchset is pushed to the master. > > On 09/07/2019 01:08, Konstantin Osipov wrote: > > * Vladislav Shpilevoy [19/07/09 01:13]: > >> Yes, you misunderstood something. This is the whole point of this > >> commit - make number of tasks not depending on a number of members. > >> On the master branch now the number of tasks per SWIM is linear of > >> cluster size - it is terrible. Both 1 and 2 tasks per member are > >> linear. > >> > >> But network load per one instance does not depend on number of members, > >> so we can make number of tasks independent from cluster size. I am trying > >> to reuse a small set of tasks for all members of one instance. Just > >> imagine - a SWIM instance knows about 500 members, and manages to work > >> with them using just 2-10 messages at once. > > > > ok, then a mempool is an overkill for sure. the comment about static global variables being unsafe still remains. Please assert or make the library thread-safe. -- Konstantin Osipov, Moscow, Russia