From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 9 Jul 2019 11:55:08 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH v2] fio: introduce utime function
Message-ID: <20190709085508.vkpe5kgrqfspmk5h@esperanza>
References: <20190705190703.22908-1-olegrok@tarantool.org>
 <20190708145110.rauvydnpn3c6hhqq@esperanza>
 <0539c600-d652-fa15-3c3f-7e1cd6fb0dee@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0539c600-d652-fa15-3c3f-7e1cd6fb0dee@tarantool.org>
To: =?utf-8?B?0J7Qu9C10LM=?= <olegrok@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Mon, Jul 08, 2019 at 06:52:24PM +0300, Олег wrote:
> 
> Thanks! My bad. I really missed it.
> 
> Please apply following diff to my patch.
> 
> diff --git a/src/lua/fio.c b/src/lua/fio.c
> index 55fa66762..48e2f8eb3 100644
> --- a/src/lua/fio.c
> +++ b/src/lua/fio.c
> @@ -709,7 +709,7 @@ lbox_fio_utime(struct lua_State *L)
>      const char *pathname = lua_tostring(L, 1);
>      double atime = lua_tonumber(L, 2);
>      double mtime = lua_tonumber(L, 3);
> -    return lbox_fio_pushbool(L, coio_utime(pathname, atime, mtime) == 0);
> +    return lbox_fio_pushbool(L, coio_utime(pathname, mtime, atime) == 0);
>  }

So, now we have:

  eio_utime(path, atime, mtime)
  coio_utime(path, mtime, atime)
  fio.utime(path, atime, mtime)

I think that for the sake of consistency coio_utime should take atime as
the second argument and mtime as the third.

Please fix and send v3 in a separate email.