From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 9 Jul 2019 10:51:36 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 4/5] memtx: fix txn_on_yield for DDL transactions
Message-ID: <20190709075135.g3yakycaitout4wp@esperanza>
References: <cover.1562357452.git.vdavydov.dev@gmail.com>
 <9fb58e54aee22309ba87fd2d6bed6bd658ab2e6d.1562357452.git.vdavydov.dev@gmail.com>
 <20190708122248.GC11062@atlas>
 <20190708164141.35f667dw7537syax@esperanza>
 <20190708215750.GD7873@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190708215750.GD7873@atlas>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Jul 09, 2019 at 12:57:50AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/08 22:14]:
> > > another way to do it is to clear fiber->txn key whenever
> > > check_format /build_index functions yield. Basically these
> > > functions run in the background, in a transaction that is
> > > temporarily detached from the main fiber so should not pollute the
> > > caller fiber key.
> > 
> > I don't get it. Need to discuss f2f.
> 
> I don't get why you need to call this from vinyl.
> 
> If both engines use the api, it should be txn_* api of course. but
> I don't get why both engines need to use it, vinyl doesn't set
> yield triggers to my knowledge.

DDL is a memtx operation, but actual index creation is done in
vinyl_space_build_index.