From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 9 Jul 2019 00:56:18 +0300 From: Konstantin Osipov Subject: Re: [PATCH 2/5] txn: run on_rollback triggers on txn_abort Message-ID: <20190708215618.GC7873@atlas> References: <20190708093201.GC8512@atlas> <20190708095746.uay7r44jxhhk5xeh@esperanza> <20190708121408.GA11062@atlas> <20190708163755.k4twfc2mrvy7zxsf@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190708163755.k4twfc2mrvy7zxsf@esperanza> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [19/07/08 22:14]: > On Mon, Jul 08, 2019 at 03:14:08PM +0300, Konstantin Osipov wrote: > > * Vladimir Davydov [19/07/08 13:02]: > > > > This manipulation should be in txn_abort(), not in > > > > txn_run_triggers(). It's txn_abort(). > > > > > > But this function is also called from completion callback, where it has > > > to set the txn as well. That's why I put it there, otherwise we would > > > have to set/restore txn context in txn_complete as well. I'm not really > > > against it - just pointint it out. I'll prepare a patch that does that, > > > see how it looks. > > > > Yes, so, basically, txn_begin(), txn_abort(), txn_complete() > > should manage the fiber key. > > Okay, please take a look at the patch below. Much safer. Thanks. LGTM. -- Konstantin Osipov, Moscow, Russia