From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 8 Jul 2019 16:51:40 +0300 From: Vladimir Davydov Subject: Re: [PATCH] vinyl: fix vy_range_update_compaction_priority hang Message-ID: <20190708135140.q7o5qbfvtnvgiuny@esperanza> References: <75dc3e64523c54640805f6d6bd798d961a75fb9e.1562592949.git.vdavydov.dev@gmail.com> <20190708134854.GA15305@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190708134854.GA15305@atlas> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Mon, Jul 08, 2019 at 04:48:54PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [19/07/08 16:38]: > > Please push this asap since there is a customer waiting for fix. Pushed to master, 2.1, and 1.10. > > Please also fix VY_ROUND_UP type safety - let's make it static > inline instead. I can't - we do need to pass double as a divident to it, because run_size_ratio is double. > > This needs a test case as a follow up and a proper fix should drop > all such slices. That's going to be tricky. I'll look if we can actually do that.