From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 8 Jul 2019 15:17:55 +0300 From: Konstantin Osipov Subject: Re: [PATCH 3/5] txn: fix execution order of commit triggers Message-ID: <20190708121755.GB11062@atlas> References: <1666e64764af9d1a144461078137fb5a7485ee34.1562357452.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1666e64764af9d1a144461078137fb5a7485ee34.1562357452.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [19/07/05 23:27]: > Both commit and rollback triggers are currently added to the list head. > As a result, they are both run in the reverse order. This is correct for > rollback triggers, because this matches the order in which statements > that added the triggers are rolled back, but this is wrong for commit > triggers. For example, suppose we create a space and then create an > index for it in the same transaction. We expect that on success we first > run the trigger that commits the space and only then the trigger that > commits the index, not vice versa. That said, reverse the order of > commit triggers in the scope of preparations for transactional DDL. > --- lgtm. -- Konstantin Osipov, Moscow, Russia