From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6478F2328E for ; Sat, 6 Jul 2019 16:35:40 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qCVEc-v9tubj for ; Sat, 6 Jul 2019 16:35:40 -0400 (EDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0C4BE23286 for ; Sat, 6 Jul 2019 16:35:39 -0400 (EDT) Received: by mail-lf1-f46.google.com with SMTP id s19so7631888lfb.9 for ; Sat, 06 Jul 2019 13:35:39 -0700 (PDT) Date: Sat, 6 Jul 2019 23:35:37 +0300 From: Cyrill Gorcunov Subject: [tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format Message-ID: <20190706203537.GC4602@uranus.lan> References: <20190705210959.8527-1-gorcunov@gmail.com> <20190705210959.8527-3-gorcunov@gmail.com> <20190705225908.GC30966@atlas> <20190706065002.GB4602@uranus.lan> <20190706160239.GA21719@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190706160239.GA21719@atlas> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Konstantin Osipov Cc: tml , Alexander Turenko On Sat, Jul 06, 2019 at 07:02:39PM +0300, Konstantin Osipov wrote: > > > > Since it gonna be new session the settings will be reset. I thought > > also that we might need to provide some box.cgf option for default > > output mode? > > Yes, but it could be box.session setting, not box.cfg. OK, will take a look, thanks! > > > Perhaps we should cache it on the client as well (this is the same > > > issue with console language). > > > > Well, seems so, still it is a bit unclear for me where to keep this > > cached value. > > I think having a default is good enough. ok > > As to "default lua" for 2.x series we need to think how to tune > > up our test engine to setup yaml mode for all tests, since currently > > test results are in yaml and we definitely don't wanna update every > > test exsiting. > > Well, at least every new test should use the new output. There > aren't that many results, and it's just results - not tests - so > they won't be hard to merge (re-run the test and compare the > diff). Besides, 1.10 is more or less frozen, it accepts only minor > bugfixes. Now it's a perfect time. got it, thanks!