From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1E72A245E6 for ; Sat, 6 Jul 2019 12:02:43 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZNwIO3JFqowr for ; Sat, 6 Jul 2019 12:02:43 -0400 (EDT) Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6A6972455A for ; Sat, 6 Jul 2019 12:02:42 -0400 (EDT) Date: Sat, 6 Jul 2019 19:02:39 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format Message-ID: <20190706160239.GA21719@atlas> References: <20190705210959.8527-1-gorcunov@gmail.com> <20190705210959.8527-3-gorcunov@gmail.com> <20190705225908.GC30966@atlas> <20190706065002.GB4602@uranus.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190706065002.GB4602@uranus.lan> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Cyrill Gorcunov Cc: tml , Alexander Turenko * Cyrill Gorcunov [19/07/06 17:40]: > On Sat, Jul 06, 2019 at 01:59:08AM +0300, Konstantin Osipov wrote: > > * Cyrill Gorcunov [19/07/06 00:13]: > > > > LGTM. @totktonada, please provide a more thorough review. > > > > One question is what happens to the output on client reconnect. > > Since it gonna be new session the settings will be reset. I thought > also that we might need to provide some box.cgf option for default > output mode? Yes, but it could be box.session setting, not box.cfg. > > Perhaps we should cache it on the client as well (this is the same > > issue with console language). > > Well, seems so, still it is a bit unclear for me where to keep this > cached value. I think having a default is good enough. > As to "default lua" for 2.x series we need to think how to tune > up our test engine to setup yaml mode for all tests, since currently > test results are in yaml and we definitely don't wanna update every > test exsiting. Well, at least every new test should use the new output. There aren't that many results, and it's just results - not tests - so they won't be hard to merge (re-run the test and compare the diff). Besides, 1.10 is more or less frozen, it accepts only minor bugfixes. Now it's a perfect time. -- Konstantin Osipov, Moscow, Russia