From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AFD8D24852 for ; Sat, 6 Jul 2019 02:50:05 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NHgscaQunXoH for ; Sat, 6 Jul 2019 02:50:05 -0400 (EDT) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 58A432484C for ; Sat, 6 Jul 2019 02:50:05 -0400 (EDT) Received: by mail-lj1-f194.google.com with SMTP id v24so11149919ljg.13 for ; Fri, 05 Jul 2019 23:50:05 -0700 (PDT) Date: Sat, 6 Jul 2019 09:50:02 +0300 From: Cyrill Gorcunov Subject: [tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format Message-ID: <20190706065002.GB4602@uranus.lan> References: <20190705210959.8527-1-gorcunov@gmail.com> <20190705210959.8527-3-gorcunov@gmail.com> <20190705225908.GC30966@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190705225908.GC30966@atlas> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Konstantin Osipov Cc: tml , Alexander Turenko On Sat, Jul 06, 2019 at 01:59:08AM +0300, Konstantin Osipov wrote: > * Cyrill Gorcunov [19/07/06 00:13]: > > LGTM. @totktonada, please provide a more thorough review. > > One question is what happens to the output on client reconnect. Since it gonna be new session the settings will be reset. I thought also that we might need to provide some box.cgf option for default output mode? > Perhaps we should cache it on the client as well (this is the same > issue with console language). Well, seems so, still it is a bit unclear for me where to keep this cached value. As to "default lua" for 2.x series we need to think how to tune up our test engine to setup yaml mode for all tests, since currently test results are in yaml and we definitely don't wanna update every test exsiting.