From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3BF6024AEC for ; Fri, 5 Jul 2019 19:04:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 57FNV4Lanifh for ; Fri, 5 Jul 2019 19:04:13 -0400 (EDT) Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EF19C2479C for ; Fri, 5 Jul 2019 19:04:12 -0400 (EDT) Date: Sat, 6 Jul 2019 02:04:10 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format Message-ID: <20190705230410.GF30966@atlas> References: <20190705210959.8527-1-gorcunov@gmail.com> <20190705210959.8527-3-gorcunov@gmail.com> <20190705225908.GC30966@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190705225908.GC30966@atlas> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Cyrill Gorcunov Cc: tml , Alexander Turenko * Konstantin Osipov [19/07/06 01:59]: > * Cyrill Gorcunov [19/07/06 00:13]: > > LGTM. @totktonada, please provide a more thorough review. > > One question is what happens to the output on client reconnect. > Perhaps we should cache it on the client as well (this is the same > issue with console language). This matter is obviously is not a blocker, can be worked on in a follow up patch. Last thing, Lua output should be the default in 2.x -- Konstantin Osipov, Moscow, Russia