From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 95BD0248F7 for ; Fri, 5 Jul 2019 19:02:10 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gaReVDLpLuWL for ; Fri, 5 Jul 2019 19:02:10 -0400 (EDT) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 58A0D2479C for ; Fri, 5 Jul 2019 19:02:10 -0400 (EDT) Date: Sat, 6 Jul 2019 02:02:08 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/2] swim: optimize struct swim_task layout Message-ID: <20190705230208.GE30966@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/07/06 01:39]: > Before the patch it was split in two parts by 1.5KB packet, and > in the constructor it was nullifying the whole volume. Obviously, > these were mistakes. The first problem breaks cache locality, > the second one flushes the cache. LGTM -- Konstantin Osipov, Moscow, Russia