From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id F18DB24BB0 for ; Fri, 5 Jul 2019 11:03:06 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OsMF-FuBh7v7 for ; Fri, 5 Jul 2019 11:03:06 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 13C1A24A4A for ; Fri, 5 Jul 2019 11:03:05 -0400 (EDT) Date: Fri, 5 Jul 2019 18:02:42 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections Message-ID: <20190705150241.p2qn7mgdfmpt2dmc@tkn_work_nb> References: <8390add718a4ba07836c2143ca3286df8c577ff3.1562316047.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8390add718a4ba07836c2143ca3286df8c577ff3.1562316047.git.avtikhon@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "Alexander V. Tikhonov" Cc: tarantool-patches@freelists.org Sorry, my bad. I forgot that I had implemented it only for core = tarantool test suites. So first implement it in test-run for core = app suites, please. WBR, Alexander Turenko. > test: use unix sockets for iproto connections It is not good to have two different commits with the same commit message header (say, you use a header to search a commit that is cherry-picked from another one). I think it worth to mention that the commit is about sql-tap if the 50 symbols limit allows. > Use unix sockets for iproto connections in sql-tap suite. > Enabled use_unix_sockets_iproto option to use unix sockets > iproto provides the new way to handle the problem with 'Use unix sockets iproto' sound as a bag of words. > 'Address already in use' error. It lets test-run appoint > unix sockets for LISTEN environment variable values. > Check the previous commit for the other suites: > > 60f84cbfca24e3a91cea067c923e006b44ee589f ('test: use unix sockets for iproto connections') > > Closes #4008 The issue is already closed, it is better to say 'Follows up #4008'. > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/use_unix_sockets_iproto_sql_tap > Issue: https://github.com/tarantool/tarantool/issues/4008 > > test/sql-tap/suite.ini | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini > index 2dfae4442..cba1d1fc6 100644 > --- a/test/sql-tap/suite.ini > +++ b/test/sql-tap/suite.ini > @@ -24,6 +24,8 @@ disabled = selectA.test.lua ; > > lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua > is_parallel = True > +use_unix_sockets = True As far as I see this option does not affect anything for core = app test suites. It is about ADMIN env variable, it is not used in app tests. Aside of that this is not mentioned in the commit message. > +use_unix_sockets_iproto = True > release_disabled = debug_mode_only.test.lua > long_run = gh-3332-tuple-format-leak.test.lua, gh-3083-ephemeral-unref-tuples.test.lua > config = engine.cfg > -- > 2.17.1 > Sasha, please check that the patch really works next time. It is in your responsibility.