From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 39CBD225E7 for ; Thu, 4 Jul 2019 03:42:10 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ls4Ne1UO0vXI for ; Thu, 4 Jul 2019 03:42:10 -0400 (EDT) Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8E22B225C3 for ; Thu, 4 Jul 2019 03:42:09 -0400 (EDT) Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1hiwNb-0007gB-KD for tarantool-patches@freelists.org; Thu, 04 Jul 2019 10:42:07 +0300 Date: Thu, 4 Jul 2019 10:42:07 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 02/10] ddl: synchronize user cache with actual data state Message-ID: <20190704074207.GA24820@atlas> References: <7d3e055e64ee3de2fb6486e4615849574b569bf4.1562181197.git.vdavydov.dev@gmail.com> <20190703194322.GJ17318@atlas> <20190703200032.hlbegritnbzbobdn@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190703200032.hlbegritnbzbobdn@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/07/03 23:05]: > > > See also commit 22bedebe715c ("ddl: synchronize privileges cache with > > > actual data state"). > > > > Here's a problem with replacing before commit: > > > > Imagine you have a yielding transaction, which is in progress. > > > > You replace state in the metadata cache, it doesn't matter what > > cache - user, view, space, trigger, or whatever. > > > > Then you yield on DDL. > > If we yield from a DDL transaction, we must invoke on_rollback triggers > immediately. I don't see any problem with that. If we don't do that now, > I'll change that soon enough. any transaction yields on WAL write. With synchronous replication it will also involve a network round trip to get a quorum responses - so a failure is more likely to happen. And then we have a cascading rollback. -- Konstantin Osipov, Moscow, Russia