From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 3 Jul 2019 22:23:03 +0300 From: Konstantin Osipov Subject: Re: [PATCH 4/6] test: make vinyl/replica_rejoin more stable Message-ID: <20190703192303.GG17318@atlas> References: <62314c2482b5d12671e713ee08f47f266e153610.1561922496.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62314c2482b5d12671e713ee08f47f266e153610.1561922496.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [19/07/01 10:04]: > The test checks that files left after rebootstrap are removed by the > garbage collector. It does that by printing file names to the result > file. This is inherently unstable, because should timing change, and > we can easily get an extra dump or compaction resulting in a different > set of files and hence test failure. Let's rewrite the test so that > it checks that files are actually removed using fio.path.exists(). lgtm -- Konstantin Osipov, Moscow, Russia