From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Wed, 3 Jul 2019 22:12:57 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [PATCH 1/6] Add ERROR_INJECT_YIELD and ERROR_INJECT_SLEEP helpers
Message-ID: <20190703191257.GD17318@atlas>
References: <cover.1561922496.git.vdavydov.dev@gmail.com>
 <fc9ba00e3e9ea286402f54431b9fb0289cb39fa1.1561922496.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fc9ba00e3e9ea286402f54431b9fb0289cb39fa1.1561922496.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/01 10:04]:
> ERROR_INJECT_YIELD yields the current fiber execution by calling
> fiber_sleep(0) while the given error injection is set.

I would sleep for some minimal non-zero time, e.g. a millisecond,
to avoid consuming CPU in parallel tests.
 
> ERROR_INJECT_SLEEP suspends the current thread execution by calling
> usleep(1000) while the given error injection is set.

LGTM.

-- 
Konstantin Osipov, Moscow, Russia