From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Fri, 28 Jun 2019 18:32:34 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v2 2/2] decimal: expose decimal type to lua.
Message-ID: <20190628153234.2572vauj3iwd2t4b@esperanza>
References: <cover.1561731259.git.sergepetrenko@tarantool.org>
 <95ad931a1e73334ca665c840da2c0aff5b6a129c.1561731259.git.sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <95ad931a1e73334ca665c840da2c0aff5b6a129c.1561731259.git.sergepetrenko@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

The patch looks good, but you haven't covered all error cases in
the test:

  https://coveralls.io/builds/24265960/source?filename=src/lua/decimal.c

Please make sure there's no red lines.

Also, I asked you during the previous review iteration, but you seem to
have overlooked it: can we please do anything about the trailing spaces?

On Fri, Jun 28, 2019 at 05:36:39PM +0300, Serge Petrenko wrote:
> +decimal.new(ffi.new('float', 128.5))
> +---
> +- '128.500000000000000'
> +...
> +decimal.new(ffi.new('double', 128.5))
> +---
> +- '128.500000000000000'
> +...
> +decimal.new(1)
> +---
> +- '1.000000000000000'
> +...
> +decimal.new(-1)
> +---
> +- '-1.000000000000000'
> +...
> +decimal.new(2^64)
> +---
> +- '18446744073709551616.000000000000000'
> +...