From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BFFA32F998 for ; Sun, 23 Jun 2019 14:38:17 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yTJdMh33jZBg for ; Sun, 23 Jun 2019 14:38:17 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EDBA12F874 for ; Sun, 23 Jun 2019 14:38:16 -0400 (EDT) Date: Sun, 23 Jun 2019 21:37:52 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH 1/1] test: fix unit/crypto test flakiness Message-ID: <20190623183752.4hl7bdduaz2puj7k@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org, georgy@tarantool.org Looks good for me. WBR, Alexander Turenko. On Sun, Jun 23, 2019 at 08:17:30PM +0200, Vladislav Shpilevoy wrote: > One of subtests was checking if crypto_decode returns an error > when fails to decode. But due to randomness of the test sometimes > it happened, that initial vector of encrypted data somehow didn't > lead to an error. Decryption was not correct, but only in terms > of result, not in terms of decryption algorithm. -1 was not > returned, and diag was not set. > > This patch checks all the cases. > > Closes #4306 > --- > Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4306-flaky-unit-crypto > Issue: https://github.com/tarantool/tarantool/issues/4306 > > [CC += Georgy] because he is an author of crypto module. > [CC += Alexander] because he is an author of the issue, and revolves around > tests.