From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B8A652FC58 for ; Sun, 23 Jun 2019 04:32:00 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YNauv8MvrbCU for ; Sun, 23 Jun 2019 04:32:00 -0400 (EDT) Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BF4D22FC4F for ; Sun, 23 Jun 2019 04:31:59 -0400 (EDT) Date: Sun, 23 Jun 2019 11:31:56 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 1/2] swim: make incarnation struct Message-ID: <20190623083156.GB7915@atlas> References: <51c439eb0ff8bb7ff46306fde45b4d8f166f3fc5.1561238125.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51c439eb0ff8bb7ff46306fde45b4d8f166f3fc5.1561238125.git.v.shpilevoy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/06/23 09:42]: > Traditional SWIM describes member version as incarnation - > volatile monotonically growing number to refute false gossips. > But it is not enough in the real world because of necessity to > detect restarts and refute information from previous lifes of an > instance. > > Incarnation is going to be a two-part value with persistent upper > part and volatile lower part. This patch does preparations making > incarnation struct instead of a number. LGTM. BTW, why is incarnation = uint64max for a non-existent member? Wouldn't it be more logical to make it int64min instead? -- Konstantin Osipov, Moscow, Russia