From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B855231446 for ; Fri, 21 Jun 2019 03:28:11 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QVNEsh10Wc_N for ; Fri, 21 Jun 2019 03:28:11 -0400 (EDT) Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 71BF731443 for ; Fri, 21 Jun 2019 03:28:11 -0400 (EDT) Date: Fri, 21 Jun 2019 10:28:09 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v4 7/9] txn: introduce asynchronous txn commit Message-ID: <20190621072809.GI18958@atlas> References: <20190620150000.kmtxnrua3iucntbf@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190620150000.kmtxnrua3iucntbf@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Vladimir Davydov [19/06/20 18:01]: > > +/* > > + * Send a transaction to a journal. > > + */ > > +int > > +txn_write(struct txn *txn) > > I'd call it txn_commit_async, becase it's just like txn_commit, but > asynchronous. I suggested the name to match the WAL api. wal-write, wal-wait and txn-write, txn-wait txn-commit is txn-write + txn-wait If you decide to change the name please follow through with the wal. -- Konstantin Osipov, Moscow, Russia