From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 92B0E30C0B for ; Thu, 20 Jun 2019 03:56:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pqpu-5ThYeqm for ; Thu, 20 Jun 2019 03:56:48 -0400 (EDT) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 52D612CAC7 for ; Thu, 20 Jun 2019 03:56:48 -0400 (EDT) Date: Thu, 20 Jun 2019 10:56:46 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v4 6/9] wal: introduce a journal entry finalization callback Message-ID: <20190620075646.GF15155@atlas> References: <079a143aa17e185c44c5fe9c53ef207d7988fe56.1560978655.git.georgy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <079a143aa17e185c44c5fe9c53ef207d7988fe56.1560978655.git.georgy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Georgy Kirichenko [19/06/20 09:54]: > + if (entry->on_done_cb) > + entry->on_done_cb(entry, entry->on_done_cb_data); A single callback is enough for today perhaps, but generally this looks exactly like a single trigger for me. Could we perhaps allocate a journal entry right in txn_new(), and move txn commit/rollback trigger objects to the journal entry object? -- Konstantin Osipov, Moscow, Russia