From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 19 Jun 2019 21:28:20 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] [PATCH v3 2/6] box: rework box_lua_{call, eval} to use input port Message-ID: <20190619182820.GD6260@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Kirill Shcherbatov List-ID: * Kirill Shcherbatov [19/06/13 17:18]: > Re-factor box_lua_call and box_lua_eval so that they don't take > call_request. This approach is more scalable: in case of a > functional index, the user expects to see a tuple with field > names so we should be able to pass not only raw msgpack, but > also a tuple to a Lua call so we need an universal way to pass > arguments to _call methods. What is is_flat? Please why do you have to ask for an explanation, shouldn't you update the declaration comment with an explanation? You also don't mention is_flat in the CS comment. -- Konstantin Osipov, Moscow, Russia