From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3EA9430B63 for ; Wed, 19 Jun 2019 14:23:32 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hiYFzrxLMPef for ; Wed, 19 Jun 2019 14:23:32 -0400 (EDT) Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E90C430B60 for ; Wed, 19 Jun 2019 14:23:31 -0400 (EDT) Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1hdfF4-0006l0-42 for tarantool-patches@freelists.org; Wed, 19 Jun 2019 21:23:30 +0300 Date: Wed, 19 Jun 2019 21:23:29 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] vinyl: don't yield in on_commit and on_rollback triggers Message-ID: <20190619182329.GC6260@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/06/16 16:11]: Basically the patch is LGTM but I would not use a mempool vy_log_tx but more strongly a a region for vy_log records - these are rare events (less than a handful a second per instance) and using a malloc for such is entirely justified. On the other hand I don't see any harm from using these (memory is not pinned for along period of time, for example), so please feel free to not bother with the comment. > +vy_log_flusher_func(va_list va) The convention is that we simply write _f for fiber functions at the end. I also did not find the place where you cancel or kill the fiber - you assume it runs forever - please document it, since otherwise the infinite fiber loop looks confusing. -- Konstantin Osipov, Moscow, Russia