From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 305633013A for ; Tue, 18 Jun 2019 09:45:40 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wpzxbFGeIewU for ; Tue, 18 Jun 2019 09:45:40 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E54CF3012D for ; Tue, 18 Jun 2019 09:45:39 -0400 (EDT) Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1hdEQb-0006Px-PI for tarantool-patches@freelists.org; Tue, 18 Jun 2019 16:45:38 +0300 Date: Tue, 18 Jun 2019 16:45:34 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] vinyl: fix assertion failure in vy_tx_handle_deferred_delete Message-ID: <20190618134534.tabkzomdbttpw74j@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Hello, On 17 Jun 18:30, Vladimir Davydov wrote: > vy_tx_handle_deferred_delete() expects (righteously) that in case a > deferred DELETE overwrites a statement in a secondary index write set > and the overwritten statement wasn't skipped on commit (i.e. doesn't > have txv->is_overwritten flag set), both the old and the new statement > must be REPLACEs (see the comment to the corresponding assertions for > more details). > > The problem is we don't set is_overwritten flag in case a statement > doesn't have any effect (txv->is_nop is set), even if it was, in fact, > overwritten in the primary index write set (see vy_tx_prepare). As > a result, we get an assertion failure when we delete such statement > in the same transaction, e.g. > > s = box.schema.space.create('test', {engine = 'vinyl'}) > s:create_index('pk', {parts = {1, 'unsigned'}}) > s:create_index('sk', {parts = {2, 'unsigned'}}) > s:replace{1, 1, 1} > box.begin() > s:update(1, {{'+', 3, 1}}) -- adds no-op REPLACE to sk write set > s:delete(1) -- produces deferred DELETE for sk > box.commit() > > results in > > vy_tx_handle_deferred_delete: Assertion `vy_stmt_type(stmt) == IPROTO_REPLACE' failed. > > Fix this by making sure we set is_overwritten for all overwritten > statements in a secondary index write set. > > Closes #4294 > --- > https://github.com/tarantool/tarantool/issues/4294 > https://github.com/tarantool/tarantool/commits/dv/gh-4294-vy-assert-failure-fix I've checked yout patch into 1.10, 2.1 and master branches. -- Regards, Kirill Yukhin