From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D2D7C2EC7B for ; Mon, 17 Jun 2019 01:16:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qkeqzdrZTUso for ; Mon, 17 Jun 2019 01:16:13 -0400 (EDT) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 29E972EA48 for ; Mon, 17 Jun 2019 01:16:13 -0400 (EDT) Date: Sun, 16 Jun 2019 19:14:00 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v3 05/14] txn: get rid of autocommit from a txn structure Message-ID: <20190616161400.GA28257@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Georgy Kirichenko [19/06/09 23:47]: > Move transaction auto start and auto commit behavior to the box level. > >From now a transaction won't start and commit automatically without > txn_begin/txn_commit invocations. This is a part of a bigger transaction > refactoring in order to implement detachable transactions and a parallel > applier. The patch is now LGTM. I agree with most of Vladimir's comments but I think they can be done in a separate patch. I will reply to his review. -- Konstantin Osipov, Moscow, Russia