From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 585AB2FC0C for ; Sat, 15 Jun 2019 06:08:35 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uNwPOf4SKS5L for ; Sat, 15 Jun 2019 06:08:35 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0BC6F2FB91 for ; Sat, 15 Jun 2019 06:08:34 -0400 (EDT) Date: Sat, 15 Jun 2019 13:08:32 +0300 From: Mergen Imeev Subject: [tarantool-patches] Re: [PATCH v1 00/28] sql: Remove SQL error system Message-ID: <20190615100832.GJ32365@tarantool.org> References: <24f3fffc-2fa3-0a56-7419-2e57aa2f5f03@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <24f3fffc-2fa3-0a56-7419-2e57aa2f5f03@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org Hi! Thank you for review! I squashed all commits with the title "Review fix". I also rebased the branch to the current master. There have been some changes due to issue 3978 (commit "sql: cleanup code from outdated macros"). However, I am not sure that these changes are enough to send a new version. Instead, I just answered patches with a review. Since both issues usually simply remove part of the unused code, in most cases the patches get shorter after the rebase. On Fri, Jun 14, 2019 at 12:24:43AM +0200, Vladislav Shpilevoy wrote: > Hi! Thanks for the patchset! > > Please, consider my review comments and fixes for some of > the patches in responses to them. > > Also I've pushed on top of the branch a new commit removing > a couple of another error codes. It is not for squash - just > a new commit. > > On 10/06/2019 16:56, imeevma@tarantool.org wrote: > > This patch-set removes unused and unnecessary code of SQL error > > system. > > > > Mergen Imeev (26): > > sql: remove field zErrMsg from struct Vdbe > > sql: remove field pErr from struct sql > > sql: remove field errCode from struct sql > > sql: remove sqlError() and remove sqlErrorWithMsg() > > sql: remove unused functions of SQL error system > > sql: disable lookaside system > > sql: remove SQL_OK error/status code > > sql: remove SQL_PERM, SQL_WARNING, SQL_ABORT errcodes > > sql: remove SQL_CANTOPEN errcode > > sql: remove SQL_NOTFOUND error/status code > > sql: remove SQL_LOCKED errcode > > sql: remove SQL_FULL errcode > > sql: remove SQL_MISUSE errcode > > sql: remove SQL_RANGE errcode > > sql: remove SQL_SCHEMA errcode > > sql: remove SQL_TOOBIG errcode > > sql: remove SQL_BUSY errcode > > sql: remove SQL_CONSTRAINT errcode > > sql: remove SQL_ERROR errcode > > sql: remove SQL_NOMEM errcode > > sql: remove SQL_IOERR errcode > > sql: remove SQL_TARANTOOL_ERROR errcode > > sql: remove field errMask from struct sql > > sql: replace rc by is_aborted in struct VDBE > > sql: remove sql_log() > > sql: remove function sqlApiExit() > > > > Nikita Pettik (2): > > sql: cleanup of legacy memory management system > > sql: make function return void instead of int > > > > src/box/bind.c | 37 +--- > > src/box/ck_constraint.c | 4 +- > > src/box/execute.c | 6 +- > > src/box/lua/lua_sql.c | 2 +- > > src/box/sql.c | 104 ++++------ > > src/box/sql/analyze.c | 2 +- > > src/box/sql/build.c | 6 +- > > src/box/sql/cursor.c | 4 +- > > src/box/sql/date.c | 14 +- > > src/box/sql/expr.c | 7 +- > > src/box/sql/fault.c | 4 +- > > src/box/sql/fk_constraint.c | 8 +- > > src/box/sql/func.c | 16 +- > > src/box/sql/global.c | 3 - > > src/box/sql/insert.c | 9 +- > > src/box/sql/legacy.c | 21 +- > > src/box/sql/main.c | 266 ++++--------------------- > > src/box/sql/malloc.c | 445 +----------------------------------------- > > src/box/sql/os.c | 14 +- > > src/box/sql/os_unix.c | 281 ++++++++------------------ > > src/box/sql/prepare.c | 73 ++----- > > src/box/sql/printf.c | 36 +--- > > src/box/sql/resolve.c | 3 +- > > src/box/sql/select.c | 61 +++--- > > src/box/sql/sqlInt.h | 173 +--------------- > > src/box/sql/status.c | 182 ----------------- > > src/box/sql/tarantoolInt.h | 11 +- > > src/box/sql/tokenize.c | 5 - > > src/box/sql/trigger.c | 2 +- > > src/box/sql/util.c | 162 --------------- > > src/box/sql/vdbe.c | 111 ++++------- > > src/box/sql/vdbeInt.h | 13 +- > > src/box/sql/vdbeapi.c | 357 +++++++++------------------------ > > src/box/sql/vdbeaux.c | 217 ++++++-------------- > > src/box/sql/vdbemem.c | 120 ++++++------ > > src/box/sql/vdbesort.c | 274 ++++++++++++-------------- > > src/box/sql/where.c | 108 +++++----- > > src/box/sql/whereexpr.c | 3 +- > > test/sql/bind.result | 8 + > > test/sql/bind.test.lua | 3 + > > test/sql/func-recreate.result | 3 +- > > 41 files changed, 726 insertions(+), 2452 deletions(-) > >