From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Fri, 14 Jun 2019 12:21:14 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH v3 06/14] txn: get rid of fiber_gc
 from txn_rollback
Message-ID: <20190614092114.fhwpvfjjw5g7kv6u@esperanza>
References: <cover.1560112747.git.georgy@tarantool.org>
 <95ba261a4768ec78f5e94596cdeb215ee1068cc2.1560112747.git.georgy@tarantool.org>
 <20190613141256.vktkk4qea4wyock4@esperanza>
 <6794812.AW9IRRbO8A@home.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6794812.AW9IRRbO8A@home.lan>
To: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= <georgy@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Jun 13, 2019 at 10:28:24PM +0300, Георгий Кириченко wrote:
> On Thursday, June 13, 2019 5:12:56 PM MSK Vladimir Davydov wrote:
> > On Sun, Jun 09, 2019 at 11:44:35PM +0300, Georgy Kirichenko wrote:
> > > Don't touch a fiber gc storage on a transaction rollback explicitly.
> ...
> > 
> > As I wrote earlier, I'm pretty convinced we don't need to call
> > fiber_gc() after txn_commit/rollback at all. Please consider
> > removing it in a separate patch.
> I call fiber_gc in such cases only in order to preserve the previous behavior. 
> I think we could remove fiber_gc when all transaction data would be placed onto 
> transaction memory. We could talk about f2f

Discussed f2f. Agreed to try to remove fiber_gc() calls after
txn_commit/rollback() first.