From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 14 Jun 2019 12:18:14 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v3 10/14] core: latch_unlock_external routine Message-ID: <20190614091814.5afs42xrfomaw7j3@esperanza> References: <98f0889a17245be64f1753012419e92c7ceef4e7.1560112747.git.georgy@tarantool.org> <20190613142735.f4aoatxq7kxnlwps@esperanza> <2220504.ES0OFZsnVI@home.lan> <20190614081008.zyuol6q6hn2qxlff@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190614081008.zyuol6q6hn2qxlff@esperanza> To: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= Cc: tarantool-patches@freelists.org List-ID: On Fri, Jun 14, 2019 at 11:10:08AM +0300, Vladimir Davydov wrote: > On Thu, Jun 13, 2019 at 10:38:12PM +0300, Георгий Кириченко wrote: > > On Thursday, June 13, 2019 5:27:35 PM MSK Vladimir Davydov wrote: > > > On Sun, Jun 09, 2019 at 11:44:39PM +0300, Georgy Kirichenko wrote: > > > > > > Again, looks like a temporary hack to me. I would rather not commit it. > > > The right way would be getting rid of the schema_lock. I know that you > > > have tried, but failed because of vylog. I'll look what we can do about > > > it. > > I failed to remove the latch from checkpoint not from ddl. Removing the latch > > from alter.cc doesn't look possible in the next 2-3 month. > > I'll look what we can do about this - AFAICS there are no problems with > memtx. We just need to tweak vinyl somehow. Discussed f2f. Looks like we can't easily remove the latch, because we do need it for synching DDL-vs-DDL (we can remove it from checkpointing, but that's not enough). Still, latch_unlock_external looks so ugly :( May be, we could move it to be called before submitting a record to WAL rather than after? Something like, before_commit trigger, may be?