From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A8576302E2 for ; Sat, 8 Jun 2019 10:24:11 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 33BZFVdl99p3 for ; Sat, 8 Jun 2019 10:24:11 -0400 (EDT) Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5D6D130264 for ; Sat, 8 Jun 2019 10:24:11 -0400 (EDT) Date: Sat, 8 Jun 2019 17:24:06 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/5] test: create isolated ev_loop for swim unit tests Message-ID: <20190608142406.GH31327@atlas> References: <50a84d1ffdd25646894e576ef4ff19195aaf769e.1559433539.git.v.shpilevoy@tarantool.org> <20190605065155.GB28736@atlas> <1b959ddd-ea04-c018-a8a9-cb8dba2b042f@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b959ddd-ea04-c018-a8a9-cb8dba2b042f@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/06/06 10:44]: > Hi! Thanks for the review. > > On 05/06/2019 09:51, Konstantin Osipov wrote: > > * Vladislav Shpilevoy [19/06/03 14:33]: > >> --- a/src/lib/swim/swim_ev.c > >> +++ b/src/lib/swim/swim_ev.c > >> @@ -55,3 +55,9 @@ swim_ev_timer_stop(struct ev_loop *loop, struct ev_timer *watcher) > >> { > >> ev_timer_stop(loop, watcher); > >> } > >> + > >> +struct ev_loop * > >> +swim_loop(void) > > > > The comment explaining why you need a separate loop should be > > here, not in the tests, since this is the place most people will > > be looking at and wondering why you need this wrapper at all. > > > > You could hack this around with a define, but I think your > > approach is more clean, so please just add a comment. > > > > It can't be solved with define, because I need swim.o. I can't > postpone preprocessor work till linking time. Otherwise we could > just implement every function in swim_ev.h and swim_transport.h > as a macros. > > The comment is moved and slightly modified. OK, thanks! -- Konstantin Osipov, Moscow, Russia