From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6AE6730BD8 for ; Fri, 7 Jun 2019 01:20:45 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tNiducBKT7iK for ; Fri, 7 Jun 2019 01:20:45 -0400 (EDT) Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1D26A30A43 for ; Fri, 7 Jun 2019 01:20:44 -0400 (EDT) Date: Fri, 7 Jun 2019 08:20:42 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections Message-ID: <20190607052042.5bbr35un3wtqm3bh@tarantool.org> References: <7c079ab85610e4f7c68662a0bff6fad3d0a4fbd7.1559881217.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7c079ab85610e4f7c68662a0bff6fad3d0a4fbd7.1559881217.git.avtikhon@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "Alexander V. Tikhonov" Cc: Alexander Turenko , tarantool-patches@freelists.org Hello, On 07 Jun 07:21, Alexander V. Tikhonov wrote: > From: avtikhon > > Enabled use_unix_sockets_iproto option to use unix sockets > iproto provides the new way to handle the problem with > 'Address already in use' error. It lets test-run appoint > unix sockets for LISTEN environment variable values. > > Before this change the TcpPortDispatcher was used to > eliminate the race condition when two workers trying to use > the same port: the idea was that each worker used its own > ports range. Really these ports could race with client ports > (from, say, net.box or replication), which typically didn't > use bind() and so bound to a random available port (despite > any dispatched ranges) and could produce 'Address already in > use' error. > > Closes: #4008 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4008-test-in-parallel-iproto > Issue: https://github.com/tarantool/tarantool/issues/4008 I've checked your patch into master and 2.1 branch. -- Regards, Kirill Yukhin