From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 457F62CA87 for ; Thu, 6 Jun 2019 22:41:21 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rhoGB5IPmokl for ; Thu, 6 Jun 2019 22:41:21 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 01E7F2CA84 for ; Thu, 6 Jun 2019 22:41:20 -0400 (EDT) Date: Fri, 7 Jun 2019 05:40:59 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v1 1/2] Enable http_client test Message-ID: <20190607024058.kvxe36zkrchoznmv@tkn_work_nb> References: <00daa2bd0e72231f71a09c80b7f45516481b3418.1559823465.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <00daa2bd0e72231f71a09c80b7f45516481b3418.1559823465.git.avtikhon@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "Alexander V. Tikhonov" Cc: tarantool-patches@freelists.org I'm okay with the code, but see minor comments below. LGTM formally, please fix the comments and proceed with Kirill directly. I would not split the patchset into two commits, just mention that you're reverts changes made by the certain commit. BTW, don't forget to write a cover letter when sending a patchset of more then one patch (it is not applicable here however if you'll squash this patchset, just reminder). Please, use prefix 'test: ' for commits that changes only tests. WBR, Alexander Turenko. On Thu, Jun 06, 2019 at 03:24:54PM +0300, Alexander V. Tikhonov wrote: > Removed skip flag file to switch on the testing of the > http_client test. Enabled http_client test on OSX, > fixed missing of the python2 link. Removed the subtest I would be more specific: link -> symlink. > on '595 error return' from 'error' suite, due to it may > hang forever. > > Closes #4254 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4254-try-on-travis > Issue: https://github.com/tarantool/tarantool/issues/4254