From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 90FF230353 for ; Thu, 6 Jun 2019 22:32:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fiixf6RboQ4R for ; Thu, 6 Jun 2019 22:32:09 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D19BB3029E for ; Thu, 6 Jun 2019 22:32:08 -0400 (EDT) Date: Fri, 7 Jun 2019 05:31:45 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v2] Fix FreeBSD build Message-ID: <20190607023145.gospow7tdmnrt7km@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Yukhin Cc: tarantool-patches@freelists.org, Vladislav Shpilevoy , "Alexander V. Tikhonov" Looks ok. CCed Vlad just in case. Verified on FreeBSD-12.0-RELEASE. It builds, but there are failed tests: * wal_off/snapshot_stress.test.lua * app-tap/minimal.test.lua * app-tap/pwd.test.lua Maybe others, I don't know: box/net_msg_max.test.lua and app-tap/tarantoolctl.test.lua hung, so the testing stucks. See also https://github.com/tarantool/tarantool/issues/4271 Kirill, can you proceed with the patch? AFAIU it is needed in master and 2.1. branch: avtikhon/freebsd-fix-build WBR, Alexander Turenko. On Wed, Jun 05, 2019 at 03:10:18PM +0300, Alexander V. Tikhonov wrote: > Fixed swim headers in addition to commit: > 88892f13a3934c72721e6240bfa5fe174d62d99b ('swim: fix build on FreeBSD') > > Included unistd.h header to fix the following errors: > > In file included from src/lib/swim/swim_transport_udp.c:31: > src/lib/swim/swim_transport.h:61:1: > error: unknown type name 'ssize_t'; did you mean 'size_t'? > ssize_t > ^~~~~~~ > size_t > /usr/include/netinet6/in6.h:698:18: note: 'size_t' declared here > typedef __size_t size_t; > ^ > In file included from src/lib/swim/swim_transport_udp.c:31: > src/lib/swim/swim_transport.h:66:1: > error: unknown type name 'ssize_t'; did you mean 'size_t'? > ssize_t > ^~~~~~~ > size_t > /usr/include/netinet6/in6.h:698:18: note: 'size_t' declared here > typedef __size_t size_t; > > Closes #4050 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/freebsd-fix-build > Issue: https://github.com/tarantool/tarantool/issues/4050 > > src/lib/swim/swim_transport.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/lib/swim/swim_transport.h b/src/lib/swim/swim_transport.h > index c4e48cdeb..31fd9af59 100644 > --- a/src/lib/swim/swim_transport.h > +++ b/src/lib/swim/swim_transport.h > @@ -32,6 +32,7 @@ > */ > #include > #include > +#include > > struct ifaddrs; > > -- > 2.17.1 >